16 comments

  • tptacek 43 minutes ago

    There's what I think is probably an awesome bug here.

    Windows-1252 encoding has a representation for lowercase German sharp 's' (ß), but not one for the uppercase. If you upcase a string containing a sharp 's', it gets normalized to "SS", which increases the length of the string by one character. The 1252 case conversion code doesn't handle this; it looks like it checks for headroom in the buffer one character at a time. So if the last character of a string you upcase is ß, it looks like you get a one-byte overflow (of 'S').

    If that's really the bug (there's a claimed RCE POC), the heap grooming for it must be really fussy! I couldn't find any other character pairs that expand like this.

    You can feed strings in 1252 to a Rails program through multipart POSTs, which get to pick their encodings.

    The great thing about this bug, apart from how it illustrates how doomed we all are (if I'm right), is that it should by rights have the best vulnerability name of the year, because you get to work 'ß' into it.

    • bee_rider a minute ago

      Haha, that exact character caused problems in a programming class I tutored for. Got to throw the first year students some curveballs.

    • testplzignore 17 minutes ago

      I wonder if there is a similar bug for U+0130 which (I think) expands to two characters when lowercased.

      • tptacek 15 minutes ago

        Maybe somewhere! But that character isn't in Windows-1252 at all, so it can't trip this string counting bug.

    • cowlevel 38 minutes ago

      Unicode also has this feature because SS is the correct uppercase form of ß

    • xp84 26 minutes ago

      Should we call it #upcaße2Shell?

      • tptacek 22 minutes ago

        One of the discoverers suggested, on Twitter, Ruby2ßhell. My wife, who speaks and writes German, refused to entertain this.

  • lousken an hour ago

    I need a vacation

    • donkey_brains an hour ago

      We all do, but we don’t know if our companies will still be there when we get back.

    • cwmoore an hour ago

      I hear Java is nice

    • _pdp_ an hour ago

      Book it for 18 months from now. Oh, also bring your laptop.

  • TZubiri an hour ago

    It should be pretty straightforward to replace regexes with good ole ifs, array acceses, and comparision operators, whether manually or with an LLM. Pretty low hanging fruit to shave off some kilobytes of attack vector

    • preinheimer 12 minutes ago

      I think you’re underestimating the complexity of a lot of regular expressions.

      • marcus_holmes 8 minutes ago

        Also that a lot of the regexes will be inside Rails code that we can't touch, Gems that need maintaining, etc.